Avoid printing autoimport syntax errors#847
Open
yangfan-yf-yf wants to merge 1 commit into
Open
Conversation
yangfan-yf-yf
marked this pull request as ready for review
July 23, 2026 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When autoimport scans an invalid source file,
get_names_from_file()prints theSyntaxErrorto standard output. On Windows consoles using GBK, a syntax error containing an unencodable character can raiseUnicodeEncodeErrorin the worker process and interrupt cache generation.This switches the diagnostic to the existing module logger at debug level. Invalid files continue to be skipped, without writing to standard output.
Validation
€; it verifies the file is skipped, the diagnostic is logged, and standard output stays empty.python -m pytest -q ropetest/contrib/autoimport/parsetest.py— 4 passedpython -m pytest -q --deselect=ropetest/contrib/autoimporttest.py::AutoImportTest::test_generate_full_cache --deselect=ropetest/contrib/autoimporttest.py::AutoImportTest::test_skipping_directories_not_accessible_because_of_permission_error— 2090 passed, 8 skipped, 5 xfailedpython -m pre_commit run --files rope/contrib/autoimport/parse.py ropetest/contrib/autoimport/parsetest.py